Merged
Conversation
I'm not sure why they were defined elsewhere, POSIX tells us where they belong. This fixes the coreutils port, which currently fails with an 'undeclared function' error.
github-actions
bot
added
the
👀 pr-needs-review
linusg
commented
Dec 6, 2025
| ) | ||
| configopts=( | ||
| '--disable-cgi' | ||
| '--disable-opcache' |
nico
reviewed
Dec 6, 2025
| #ifndef ZEND_WIN32 | ||
| # include <sys/types.h> | ||
| # include <sys/wait.h> | ||
| -# include <sys/ipc.h> |
Contributor
There was a problem hiding this comment.
Should we add an empty sys/ipc.h instead of this patch?
Contributor
There was a problem hiding this comment.
(to be clear,.this is not blocking or anything)
Member
Author
There was a problem hiding this comment.
Not in favor of that personally. In this specific case it seems like the include is unused (as per https://pubs.opengroup.org/onlinepubs/007904975/basedefs/sys/ipc.h.html it defines ftok() and a handful of IPC_ constants, none of which seem to be used here) so we got lucky. If they were used we'd have to patch out more things, so an empty header is unlikely to be generally useful.
Contributor
There was a problem hiding this comment.
Should we remove the include upstream then?
linusg
added a commit
to linusg/php-src
that referenced
this pull request
Dec 6, 2025
As far as I can tell that's been there since the initial open source release (commit 528006a). The header defines ftok() and a handful of IPC_* constants, none of which are used here. System V IPC is increasingly being replaced by POSIX IPC and may therefore not be implemented on new and/or hobbyist operating systems such as SerenityOS[1]. In the past that wasn't an issue as the OPCache could be disabled, which is no longer possible as of PHP 8.5[2]. I was able to build with the include patched out, but we would prefer this to be addressed upstream. 1: SerenityOS/serenity#26465 2: php#18961
github-actions
bot
removed
the
👀 pr-needs-review
ndossche
pushed a commit
to php/php-src
that referenced
this pull request
Dec 7, 2025
As far as I can tell that's been there since the initial open source release (commit 528006a). The header defines ftok() and a handful of IPC_* constants, none of which are used here. System V IPC is increasingly being replaced by POSIX IPC and may therefore not be implemented on new and/or hobbyist operating systems such as SerenityOS[1]. In the past that wasn't an issue as the OPCache could be disabled, which is no longer possible as of PHP 8.5[2]. I was able to build with the include patched out, but we would prefer this to be addressed upstream. 1: SerenityOS/serenity#26465 2: #18961
ndossche
pushed a commit
to php/php-src
that referenced
this pull request
Dec 8, 2025
As far as I can tell that's been there since the initial open source release (commit 528006a). The header defines ftok() and a handful of IPC_* constants, none of which are used here. System V IPC is increasingly being replaced by POSIX IPC and may therefore not be implemented on new and/or hobbyist operating systems such as SerenityOS[1]. In the past that wasn't an issue as the OPCache could be disabled, which is no longer possible as of PHP 8.5[2]. I was able to build with the include patched out, but we would prefer this to be addressed upstream. 1: SerenityOS/serenity#26465 2: #18961
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.